-
Notifications
You must be signed in to change notification settings - Fork 10.4k
gRPC JSON transcoding — Fixed parsing string values into enum when provided string is not valid enum value #52402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JamesNK
merged 3 commits into
dotnet:main
from
zorix:fix-handling-not-alloawed-string-values-in-enums
Nov 29, 2023
Merged
gRPC JSON transcoding — Fixed parsing string values into enum when provided string is not valid enum value #52402
JamesNK
merged 3 commits into
dotnet:main
from
zorix:fix-handling-not-alloawed-string-values-in-enums
Nov 29, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for your PR, @zorix. Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
@dotnet-policy-service agree |
JamesNK
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Some minor changes to the error message and variable names.
...JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/EnumConverter.cs
Outdated
Show resolved
Hide resolved
...est/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs
Outdated
Show resolved
Hide resolved
...est/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs
Outdated
Show resolved
Hide resolved
...est/Microsoft.AspNetCore.Grpc.JsonTranscoding.Tests/ConverterTests/JsonConverterReadTests.cs
Outdated
Show resolved
Hide resolved
c60f1da
to
80de8ba
Compare
JamesNK
reviewed
Nov 29, 2023
...JsonTranscoding/src/Microsoft.AspNetCore.Grpc.JsonTranscoding/Internal/Json/EnumConverter.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: James Newton-King <[email protected]>
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area-grpc
Includes: GRPC wire-up, templates
community-contribution
Indicates that the PR has been added by a community member
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed parsing string values into enum when provided string is not valid enum value
NullReferenceException is thrown when string value cannot be converted to gRPC enum value.
Description
Right now when we provided JSON string value (for example
INVALID
) into gRPC enum like this (I took it from tests)We will get
NullReferenceException
in this line becausevalueDescriptor
won't be found.Not related issue found