Skip to content

Fix reading null struct property value in gRPC JSON transcoding #52442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 29, 2023

Fixes #51521

Reading null struct property values was erroring because a Struct requires null Value. Fix by converting null reference to a null Value by updating the converter to handle null.

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Nov 29, 2023
@JamesNK JamesNK changed the title Fix reading null struct property value Fix reading null struct property value in gRPC JSON transcoding Nov 29, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Nov 29, 2023

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@JamesNK JamesNK merged commit 9324f30 into main Nov 29, 2023
@JamesNK JamesNK deleted the jamesnk/grpc-json-struct-null branch November 29, 2023 23:22
@ghost ghost added this to the 9.0-preview1 milestone Nov 29, 2023
@JamesNK
Copy link
Member Author

JamesNK commented Nov 30, 2023

/backport to release/8.0

Copy link
Contributor

Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7040801995

@alrz
Copy link
Member

alrz commented Dec 6, 2023

I suppose because the fix is on Value converter [null] will work as well. I've found another converter that handles null but it's not configured properly: EnumConverter

@ghost
Copy link

ghost commented Dec 6, 2023

Hi @alrz. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot deserialize into google.protobuf.NullValue in gRPC JSON transcoding
3 participants