Fix auto import of proto files when gRPC JSON transcoding is a transitive reference #52443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
captainsafia
approved these changes
Nov 29, 2023
ghost
added this to the
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7040803125 |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52006
gRPC JSON transcoding has a Cool Trick to bundle proto files in the package and automatically include them in the proto compilation. This uses msbuild that is shipped with in the nuget package.
The msbuild file is in the package's
/builddirectory, which means it doesn't run when Microsoft.AspNetCore.Grpc.JsonTranscoding is transitively referenced by the web app. The fix is to also put it in/buildTransitive.The workaround to this issue is to add a direct reference to Microsoft.AspNetCore.Grpc.JsonTranscoding.