Skip to content

Add endpoint metadata to developer exception page #52668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 7, 2024
Merged

Add endpoint metadata to developer exception page #52668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2aee7e
Add endpoint metadata to developer exception page
Kahbazi Dec 8, 2023
49d8bc4
Add test
Kahbazi Dec 8, 2023
79ebd01
handle null endpoint
Kahbazi Dec 8, 2023
5137c2f
Handle null metadata
Kahbazi Dec 8, 2023
4c9181c
Address review feedbacks
Kahbazi Dec 15, 2023
96c3b4b
Handle null reference
Kahbazi Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...Middleware/Diagnostics/src/DeveloperExceptionPage/DeveloperExceptionPageMiddlewareImpl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,8 +320,11 @@ private Task DisplayRuntimeException(HttpContext context, Exception ex)
EndpointModel? endpointModel = null;
if (endpoint != null)
{
endpointModel = new EndpointModel();
endpointModel.DisplayName = endpoint.DisplayName;
endpointModel = new EndpointModel
{
DisplayName = endpoint.DisplayName,
Metadata = endpoint.Metadata
};

if (endpoint is RouteEndpoint routeEndpoint)
{
Expand Down
3 changes: 3 additions & 0 deletions src/Middleware/Diagnostics/src/DeveloperExceptionPage/Views/EndpointModel.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using Microsoft.AspNetCore.Http;

namespace Microsoft.AspNetCore.Diagnostics.RazorViews;

internal sealed class EndpointModel
Expand All @@ -9,4 +11,5 @@ internal sealed class EndpointModel
public string? RoutePattern { get; set; }
public int? Order { get; set; }
public string? HttpMethods { get; set; }
public EndpointMetadataCollection? Metadata { get; set; }
}
Loading