-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/8.0] Fix NavigationManager.Refresh() on SSR-only pages #52767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* implement NavigationManager.Refresh() on ssr pages --------- Co-authored-by: Steve Sanderson <[email protected]>
Hi @surayya-MS. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
Hi @surayya-MS. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Hi @surayya-MS. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved as this is a backport PR which was approved already.
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
This test fails I think it is a flaky test because I merged this same change to cc @dotnet/aspnet-blazor-eng, @wtgodbe |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@MackinnonBuck @mkArtakMSFT there's a merge conflict here, who can take a look at it now that Surayya is off the team? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
The test failures seem to be caused by EF migrations not being able to apply:
Not yet sure why this would suddenly start happening. |
Test failures are unrelated |
Fix NavigationManager.Refresh() on SSR-only pages
Manual backport of #52559
Description
NavigationManager.Refresh()
andNavigationManager.NavigateTo({current url})
.Fixes #51222
Fixes #51482
Customer Impact
Without this change customers will not be able to use
NavigationManager.Refresh()
in SSR-only pages. Also, the behavior forNavigationManager.NavigateTo({current url})
changes - no history entry is pushed.Regression?
[If yes, specify the version the behavior has regressed from]
Risk
This is a minor change. There are e2e tests for this change as well as manual testing was done.
The important thing is that newly introduced enhanced navigation feauture's behavior is changed in this PR: when enhanced navigation is on `NavigationManager.NavigateTo({current url}) doesn't push new history entry (it did that before). Hence this should be patched as soon as possible.
Verification
Packaging changes reviewed?
When servicing release/2.1