Fix SSR page rendering intermediate state instead of the end state of components #52823
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
src/Components/Endpoints/src/Rendering/EndpointHtmlRenderer.Prerendering.cs
Outdated
Show resolved
Hide resolved
|
@surayya-MS This approach looks perfect to me. It's reassuring that nothing weird is going on and we just need to extend our use of the same pattern. Thanks for figuring this out! |
surayya-MS
commented
Dec 18, 2023
javiercn
reviewed
Dec 20, 2023
...ssets/Components.TestServer/RazorComponents/Components/ChildComponentThatDelaysLoading.razor
Outdated
Show resolved
Hide resolved
javiercn
reviewed
Dec 20, 2023
...sets/Components.TestServer/RazorComponents/Components/ParentComponentThatDelaysLoading.razor
Outdated
Show resolved
Hide resolved
javiercn
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Looks great!
A small tweak to the tests, if you want to make something asynchronous, Task.Yield() is better than Task.Delay() it does the same thing and we aren't adding time to the test run (imagine this over 60 tests, it adds 1 minute to the test run, and so on).
As long as we change, the rest looks good.
…onents/Components/ChildComponentThatDelaysLoading.razor Co-authored-by: Javier Calvarro Nelson <[email protected]>
…onents/Components/ParentComponentThatDelaysLoading.razor Co-authored-by: Javier Calvarro Nelson <[email protected]>
surayya-MS
added a commit
to surayya-MS/aspnetcore
that referenced
this pull request
Dec 21, 2023
… components (dotnet#52823) * finish all non streaming pending tasks before rendering ssr page * fix tests * refactor fix for the tests * call Dispatcher.AssertAccess() in AddPendingTask() * add e2e test * fix post request await all non streaming pending tasks; add e2e test * move NonStreamingPendingTasks class to another file * save WaitForNonStreamingPendingTasks into a variable * Update src/Components/test/testassets/Components.TestServer/RazorComponents/Components/ChildComponentThatDelaysLoading.razor Co-authored-by: Javier Calvarro Nelson <[email protected]> * Update src/Components/test/testassets/Components.TestServer/RazorComponents/Components/ParentComponentThatDelaysLoading.razor Co-authored-by: Javier Calvarro Nelson <[email protected]> --------- Co-authored-by: Javier Calvarro Nelson <[email protected]>
11 tasks
wtgodbe
pushed a commit
that referenced
this pull request
Jan 4, 2024
… components (#52823) (#52943) * finish all non streaming pending tasks before rendering ssr page * fix tests * refactor fix for the tests * call Dispatcher.AssertAccess() in AddPendingTask() * add e2e test * fix post request await all non streaming pending tasks; add e2e test * move NonStreamingPendingTasks class to another file * save WaitForNonStreamingPendingTasks into a variable * Update src/Components/test/testassets/Components.TestServer/RazorComponents/Components/ChildComponentThatDelaysLoading.razor * Update src/Components/test/testassets/Components.TestServer/RazorComponents/Components/ParentComponentThatDelaysLoading.razor --------- Co-authored-by: Javier Calvarro Nelson <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSR page rendering intermediate state instead of the end state of components
The problem was that not all non streaming pending tasks are awaited.
By the time it reaches this line not all non streaming pending tasks are in the list. Later other tasks can be added by child components.
I used a similar technique to correctly await all the non streaming pending tasks that is already is used here.
Same problem when post requests awaits non streaming pending tasks. Not all non streaming pending tasks are in the list. Later other tasks can be added by child components.
Fixes #52131
Fixes #52871