You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Microsoft.AspNetCore.Components.WebView.props not getting packed correctly
Fixes an issue where Microsoft.AspNetCore.Components.WebView.props was not getting packed correctly. This was causing build failures for any project referencing Microsoft.AspNetCore.Components.WebView.
If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of Microsoft.AspNetCore.Components.WebView until this issue gets fixed.
Regression?
Yes
No
Regressed from package version 7.0.14.
Risk
High
Medium
Low
The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A MAUI dependency update was failing due to this bug, and the fix has shown to address it.
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.
MackinnonBuck
added
the
ask-mode
This issue / PR is a patch candidate which we will bar-check internally before patching it.
label
Dec 22, 2023
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime.
To make sure no conflicting changes have occurred, please rerun validation before merging. You can do this by leaving an /azp run comment here (requires commit rights), or by simply closing and reopening.
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
MackinnonBuck
added
the
ask-mode
ghost
added
the
pending-ci-rerun
mkArtakMSFT
added
Servicing-approved
Backport of #52638 to release/7.0
/cc @MackinnonBuck
Fix
Microsoft.AspNetCore.Components.WebView.propsnot getting packed correctlyFixes an issue where
Microsoft.AspNetCore.Components.WebView.propswas not getting packed correctly. This was causing build failures for any project referencingMicrosoft.AspNetCore.Components.WebView.Description
Fixes #52637
Customer Impact
If customers were to reference a new version of this package without this fix, their app would fail to build. Our temporary workaround is to avoid shipping new versions of
Microsoft.AspNetCore.Components.WebViewuntil this issue gets fixed.Regression?
Regressed from package version 7.0.14.
Risk
The fix is straightforward, and we've verified that the packages produced in CI contain the correct assets. A MAUI dependency update was failing due to this bug, and the fix has shown to address it.
Verification
Packaging changes reviewed?