-
Notifications
You must be signed in to change notification settings - Fork 10.4k
[release/8.0] Fix handling of default values for struct types in RDG #53047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document. |
@captainsafia can you get this one approved/servicing approved? |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge. To learn more about how to prepare a servicing PR click here. |
Hi @github-actions[bot]. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed. |
Approved via email. |
Backport of #51193 to release/8.0
/cc @captainsafia
Description
The current strategy for generating string literals for given defaults values in RDG does not handle the full spectrum
Closes #51183.
Customer Impact
Without this bug fix, RDG may generate uncompilable code for scenarios where the users may be defining parameters with default values that have a struct type. There is no viable workaround to users for this issue (outside of disabling compile-time codegen).
Regression?
Risk
As part of this work, we've added test coverage to validate the behavior of codegen for parameters with default values of various struct and value types. Tests indicate that new logic works as expected for the this set of built-in types.
Verification
Packaging changes reviewed?