Skip to content

[release/6.0] Use SHA256 for RPM digest #53158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

NikolaMilosavljevic
Copy link
Member

Backport of #52664

FIPS compliance blocks installation of RPM packages that use MD5 digest algorithm. We use fpm tool which defaults to MD5 digests. The fix is to specify SHA256 instead.

The fix was made in arcade with dotnet/arcade#14269, installer fix is in dotnet/installer#17933

This is the same fix that was made by many other RPM package owners, for instance: https://github.com/influxdata/telegraf

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 4, 2024
@ghost ghost added this to the 6.0.x milestone Jan 4, 2024
@ghost
Copy link

ghost commented Jan 4, 2024

Hi @NikolaMilosavljevic. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Jan 4, 2024

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@NikolaMilosavljevic NikolaMilosavljevic added the Servicing-consider Shiproom approval is required for the issue label Jan 4, 2024
@ghost
Copy link

ghost commented Jan 4, 2024

Hi @NikolaMilosavljevic. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@NikolaMilosavljevic NikolaMilosavljevic added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 5, 2024
@ghost
Copy link

ghost commented Jan 5, 2024

Hi @NikolaMilosavljevic. This PR was just approved to be included in the upcoming servicing release. Somebody from the @dotnet/aspnet-build team will get it merged when the branches are open. Until then, please make sure all the CI checks pass and the PR is reviewed.

@NikolaMilosavljevic
Copy link
Member Author

This was approved for servicing.

@NikolaMilosavljevic NikolaMilosavljevic added the * NO MERGE * Do not merge this PR as long as this label is present. label Jan 8, 2024
@NikolaMilosavljevic
Copy link
Member Author

Not merging to minimize risk for .NET 6 customers.

@ghost
Copy link

ghost commented Jan 9, 2024

Hi @NikolaMilosavljevic. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@wtgodbe wtgodbe removed the * NO MERGE * Do not merge this PR as long as this label is present. label Mar 6, 2024
@wtgodbe
Copy link
Member

wtgodbe commented Mar 6, 2024

@NikolaMilosavljevic do we want to take this for April?

@wtgodbe
Copy link
Member

wtgodbe commented Mar 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@NikolaMilosavljevic
Copy link
Member Author

@NikolaMilosavljevic do we want to take this for April?

That's the plan, but we're circling back with Tactics tomorrow, before merging the PRs.

@leecow

@rbhanda rbhanda modified the milestones: 6.0.x, 6.0.29 Mar 7, 2024
@NikolaMilosavljevic
Copy link
Member Author

@wtgodbe this can be merged now. I don't have permissions.

@wtgodbe wtgodbe merged commit 2f81f3e into dotnet:release/6.0 Mar 12, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestone: 6.0.29 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework Servicing-approved Shiproom has approved the issue
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants