Enable gRPC tests on MacOS 12 #53186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like Helix-matrix is still running MacOS11 - I'd suggest updating this line to 12: aspnetcore/eng/targets/Helix.Common.props Line 52 in d66ca7b Then queueing a build of helix-matrix against your branch: https://dev.azure.com/dnceng-public/public/_build?definitionId=85 |
wtgodbe
approved these changes
Jan 8, 2024
JamesNK
force-pushed
the
jamesnk/grpc-macos
branch
from
4241ed1 to
59f8de5
Compare
2 tasks
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47336
Newer versions of Grpc.Tools didn't support MacOS 11. See #47336.
aspnetcore is building on 12 so it's no longer a problem.
@wtgodbe How can I ensure the changes succeed on a full Helix build?