Skip to content

[Infrastructure] [release/8.0] Update eslint js doc plugin #53220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[Infrastructure] [release/8.0] Update eslint js doc plugin #53220

wants to merge 3 commits into from

Conversation

MackinnonBuck
Copy link
Member

Backport of #51816.

Will hopefully fix some source build errors we've been seeing.

@javiercn @MackinnonBuck
[Infrastructure] Update eslint js doc plugin (#51816)
8b5e155 
* Enables the repo to build with node 20.x which is the current LTS
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 8, 2024
@ghost ghost added this to the 8.0.x milestone Jan 8, 2024
@MackinnonBuck MackinnonBuck changed the title [Infrastructure] [release/8.0] Update eslint js doc plugin (#51816) [Infrastructure] [release/8.0] Update eslint js doc plugin Jan 8, 2024
@ghost
Copy link

ghost commented Jan 8, 2024

Hi @MackinnonBuck. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@ghost
Copy link

ghost commented Jan 8, 2024

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@MackinnonBuck MackinnonBuck mentioned this pull request Jan 8, 2024
Merged
@MackinnonBuck MackinnonBuck added the tell-mode Indicates a PR which is being merged during tell-mode label Jan 8, 2024
@MackinnonBuck
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MackinnonBuck
Copy link
Member Author

This PR makes the build get slightly further than it did before, but it looks like the PackageOutputPath MSBuild property is empty, and that's causing issues on this line. I haven't yet been able to debug the cause of this.

@MackinnonBuck
Copy link
Member Author

Closing since #53234 should fix this

@ghost
Copy link

ghost commented Jan 9, 2024

Hi @MackinnonBuck. It looks like you just commented on a closed PR. The team will most probably miss it. If you'd like to bring something important up to their attention, consider filing a new issue and add enough details to build context.

@MackinnonBuck MackinnonBuck deleted the mbuck/backport-51816-to-8.0 branch November 5, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtgodbe wtgodbe wtgodbe approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy BrennanConroy will be requested when the pull request is marked ready for review BrennanConroy is a code owner

@halter73 halter73 Awaiting requested review from halter73 halter73 will be requested when the pull request is marked ready for review halter73 is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
Servicing
Status: In Progress
Milestone
8.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@MackinnonBuck @wtgodbe @javiercn