Add option to serve WebAssembly app with multithreading #54062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
SteveSandersonMS
added
the
api-ready-for-review
dotnet-policy-service
bot
removed
the
api-ready-for-review
SteveSandersonMS
added
the
api-ready-for-review
dotnet-policy-service
bot
removed
the
api-ready-for-review
javiercn
reviewed
Feb 16, 2024
| endpointBuilder.RequestDelegate = httpContext => | ||
| { | ||
| httpContext.Response.Headers["Cross-Origin-Embedder-Policy"] = "require-corp"; | ||
| httpContext.Response.Headers["Cross-Origin-Opener-Policy"] = "same-origin"; |
There was a problem hiding this comment.
Can this be same-origin-allow-popups? If we are not having a way to configure this, we should at least be as lax as possible while enabling the feature.
There was a problem hiding this comment.
No, unfortunately that's not enough for SharedArrayBuffer to be enabled. It has to be same-origin.
javiercn
reviewed
Feb 16, 2024
|
|
||
| namespace Microsoft.AspNetCore.Components.E2ETest.Tests; | ||
|
|
||
| public class ThreadingHostedAppTest |
There was a problem hiding this comment.
Is it worth having a dev server test?
There was a problem hiding this comment.
There already is one - see ThreadingAppTest.
javiercn
approved these changes
Feb 17, 2024
This was referenced Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For detailed information, see the API review issue at #54071
PR review notes
The product logic change is very small - it's just the changes in these two files:
Everything else is tests.
When merged, we can also mark #53723 as
test-fixed.