Install java via native tools in CI #54421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VMR doesn't have Java installed globally on the machines, but it does have it in the native tool cache. This PR updates the build scripts to use the native tool cache to install Java in CI builds. I've also updated to 11.0.22 (vs. the .3 version from 2019) and the script used to pull this from native tool assets.
ghost
added
the
area-infrastructure
wtgodbe
reviewed
Mar 7, 2024
.azure/pipelines/ci.yml
Outdated
| @@ -200,7 +200,8 @@ stages: | |||
| steps: | |||
| - script: ./eng/build.cmd | |||
| -ci | |||
| -prepareMachine | |||
| -prepareMchine | |||
| -nativeToolsOnMachine | |||
wtgodbe
reviewed
Mar 7, 2024
| @@ -12,8 +12,6 @@ | |||
| "$(MicrosoftNETCoreBrowserDebugHostTransportVersion)" | |||
| ] | |||
| }, | |||
| "Git": "2.22.0", | |||
There was a problem hiding this comment.
This doesn't do anything that I can tell. Do you know of any place that reads this? Btw last updated in 2019?
wtgodbe
approved these changes
Mar 7, 2024
|
This needs a tweak or two. |
|
Do we need something similar for wasm-tools? Edit: ignore me - this is apparently known and the new requirement is being reverted. Out of curiosity, would the fix look like this, if we were going to install it? |
Because the native tools are laid out in a weird way...this doenst' work locally...i'll need to disable native tools installs unless the native tools are on the machine |
|
@mmitche, we've been seeing a lot of failures in Do we need to revert this? Or do a follow-up? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMR doesn't have Java installed globally on the machines, but it does have it in the native tool cache like other CI machines. This PR updates the build scripts to use the native tool cache to install Java in CI builds. I've also updated to 11.0.22 (vs. the .3 version from 2019) and the script used to pull this from native tool assets storage account.