Skip to content

Use the VMR commit hash in .version #54461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

omajid
Copy link
Member

@omajid omajid commented Mar 9, 2024

This puts the VMR's commit hash, provided by the VMR as the property DotNetGitCommitHash, in the .version file.

Contributes to dotnet/source-build#3643

This puts the VMR's commit hash, provided by the VMR as the property
DotNetGitCommitHash, in the .version file.

Contributes to dotnet/source-build#3643
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Mar 9, 2024
@wtgodbe wtgodbe merged commit 818d0e3 into dotnet:main Mar 12, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview3 milestone Mar 12, 2024
omajid added a commit to omajid/dotnet-aspnetcore that referenced this pull request Mar 19, 2024
This reverts commit 818d0e3.

Over at dotnet/installer#18941, we decied that
we wanted to go in a different (and simpler!) direction. We will make
sure `SourceRevisionId` is defined/used correctly everywhere.
wtgodbe pushed a commit that referenced this pull request Mar 19, 2024
This reverts commit 818d0e3.

Over at dotnet/installer#18941, we decied that
we wanted to go in a different (and simpler!) direction. We will make
sure `SourceRevisionId` is defined/used correctly everywhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants