Skip to content

Simplify Publishing.props #54566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 20, 2024
Merged

Simplify Publishing.props #54566

merged 6 commits into from
Mar 20, 2024

Conversation

ViktorHofer
Copy link
Member

No description provided.

@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 15, 2024
@ViktorHofer ViktorHofer marked this pull request as ready for review March 20, 2024 07:18
@ViktorHofer ViktorHofer requested review from wtgodbe and a team as code owners March 20, 2024 07:18
@wtgodbe
Copy link
Member

wtgodbe commented Mar 20, 2024

I see this changes NonShipping=true to IsShipping=false - will that fix issues like the following:

##[error].packages\microsoft.dotnet.arcade.sdk\9.0.0-beta.24168.5\tools\Publish.proj(176,5): error MSB4096: (NETCORE_ENGINEERING_TELEMETRY=Publish) The item "D:\a_work\1\s\artifacts\installers\Release\ancm_iis_express_arm64_en_v2_9.0.0-preview.4.24170.1.msi.sha512" in item list "ItemsToPushToBlobFeed" does not define a value for metadata "IsShipping". In order to use this metadata, either qualify it by specifying %(ItemsToPushToBlobFeed.IsShipping), or ensure that all items in this list define a value for this metadata.

I think the last Arcade update introduced those

@ViktorHofer ViktorHofer enabled auto-merge (squash) March 20, 2024 19:25
@wtgodbe wtgodbe disabled auto-merge March 20, 2024 19:26
@wtgodbe wtgodbe merged commit 38b8d1c into main Mar 20, 2024
@wtgodbe wtgodbe deleted the ViktorHofer-patch-1 branch March 20, 2024 19:26
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
9.0-preview4
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @wtgodbe @akoeplinger