Switch to 1ES templates #54651
Merged
Switch to 1ES templates #54651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
|
Once the internal build passes I'll switch our public CI over to using the public yml file |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
RussKie
approved these changes
Mar 21, 2024
| buildConfiguration: $(BuildConfiguration) | ||
| buildPlatform: $(AgentOsName) | ||
|
|
||
| - ${{ if eq(variables['System.TeamProject'], 'internal') }}: |
There was a problem hiding this comment.
As discussed offline, I would split these steps into own file for the ease of maintenance. I'd name these files something like build-public.yml and buid-internal.yml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/dotnet/aspnetcore-internal/issues/4468
We unfortunately have to bifurcate our .yml files into a
ci.yml(internal) andci-public.yml(public) as part of this, which means we have some duplicated code. Would be good to clean some of that up in the future.Latest test build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2409961&view=results