Fix developer exception page showing duplicate endpoint metadata #54893
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesNK
added
the
area-middleware
Kahbazi
approved these changes
Apr 2, 2024
| <td><span title="@(metadata.GetType().FullName ?? string.Empty)">@metadata.GetType().Name</span></td> | ||
| <td>@(metadata.ToString() ?? string.Empty)</td> | ||
| <td> | ||
| @{ |
There was a problem hiding this comment.
Oops! Sorry, I was trying to get feedback on which way was better to do. #52668 (comment)
Since some times has been passed, I forgot about it!
amcasey
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to add metadata to the developer exception page accidentally included some test code. This caused metadata to be duplicated. Also,
HtmlEncodeAndReplaceLineBreaksoutput was encoded again.This PR:
HtmlEncodeAndReplaceLineBreaksdirectly to outputAfter: