Skip to content

[release/6.0] Don't build Node components in SourceBuild #54913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2024
Merged

[release/6.0] Don't build Node components in SourceBuild #54913

merged 1 commit into from
Apr 2, 2024

Conversation

wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Apr 2, 2024

Switching to 1ES put us on a pool where Node is available - we didn't used to have to pass this arg to skip the node build, but now we do.

@wtgodbe wtgodbe added the tell-mode Indicates a PR which is being merged during tell-mode label Apr 2, 2024
@wtgodbe wtgodbe requested a review from a team as a code owner April 2, 2024 21:42
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 2, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone Apr 2, 2024
@wtgodbe wtgodbe merged commit c894b55 into release/6.0 Apr 2, 2024
@wtgodbe wtgodbe deleted the wtgodbe/SB6 branch April 2, 2024 23:03
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.30 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework tell-mode Indicates a PR which is being merged during tell-mode
Projects
None yet
Milestone
6.0.30
Development

Successfully merging this pull request may close these issues.
1 participant
@wtgodbe