Skip to content

Docs: changed to align with function behaviour. #54965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bseptember
Copy link
Contributor

Documentation change for Html.HiddenFor #49415

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Summary of changes

Changed a sentence to indicate that htmlAttributes parameter is not used.

Description

This pull request deals with Issue #49415, which is related to how HtmlHelper.HiddenFor() works in .NET 6 and up. The issue arises when the Model's property is empty, and a value is given in the htmlAttributes parameter. The way it currently behaves is not in line with what is explained in the documentation. Therefore, the documentation has been updated accordingly.

Please review, thanks!.

Fixes #49415 (documentation changed)

@bseptember bseptember requested a review from a team as a code owner April 5, 2024 11:04
@ghost ghost added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 5, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 5, 2024
@amcasey amcasey added the area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages label Apr 5, 2024
@captainsafia captainsafia merged commit 616226b into dotnet:main Apr 5, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-ui-rendering Includes: MVC Views/Pages, Razor Views/Pages community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect documentation for Html.HiddenFor: Html.HiddenFor will never use value property from htmlAttributes to assign value
3 participants