-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Improve the style for developer exception page #55042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ElderJames! LGTM, but let's give @JamesNK a chance to comment, since he filed the issues.
I tested it out and pushed some changes to your branch.
@ElderJames What do you think? |
@JamesNK It looks better. You reminded me that I should change the font size of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine either way.
As I said before, just changing the css file isn't enough. The css file is embedded in the developer exception page by the Razor compiler, and that happens at dev time. For future reference: https://github.com/dotnet/aspnetcore/tree/main/src/Middleware/Diagnostics/src#aspnet-core-diagnostics I made some more changes:
I think this is good to merge. |
@JamesNK Thank you for figure out the razor compilation, I didn't know it before. |
Merged. Thanks! |
Improve the style for developer exception page
Summary of the changes (Less than 80 chars)
Just changed the word breaking style and font size to 10% larger.
Description
before:

after:

Fixes #54894 Fixes #54896