Enable building native projects for windows arm64 #55145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
akoeplinger
commented
Apr 15, 2024
| @@ -150,7 +150,7 @@ param( | |||
| [ValidateSet('Debug', 'Release')] | |||
| $Configuration, | |||
|
|
|||
| [ValidateSet('x64', 'x86', 'arm', 'arm64')] | |||
| [ValidateSet('x64', 'x86', 'arm64')] | |||
There was a problem hiding this comment.
32bit arm on windows was removed in .NET 5 so we don't need to check it anymore
wtgodbe
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building aspnetcore for windows arm64 in the VMR.
Description
Right now the native projects are only built when targetting x86/x64 architectures. This causes an issue in the VMR because we're building windows arm64 in a separate job and aspnetcore fails because of the missing native assets.
The desktop msbuild build for the native projects was disabled for arm64, enable it to match the other architectures.