Skip to content

Remove GET_RequestReturnsLargeData_GracefulShutdownDuringRequest_RequestGracefullyCompletes #58738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Nov 1, 2024

This test has always failed and been quaratined since the beginning. Changes need to be made to Kestrel/sockets transport to support this scenario.

There is no point having a test that doesn't test anything useful and fails. Right now it creates confusion when folks run tests locally and see it fail.

Fixes #52238

@JamesNK JamesNK added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label Nov 1, 2024
@BrennanConroy
Copy link
Member

Changes need to be made to Kestrel/sockets transport to support this scenario.

Can you elaborate?

@JamesNK
Copy link
Member Author

JamesNK commented Nov 2, 2024

Details ae in #41074

Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we instead skip the test and point to #41074?

@JamesNK JamesNK enabled auto-merge (squash) November 5, 2024 07:52
@JamesNK JamesNK merged commit ffabb29 into main Nov 5, 2024
27 checks passed
@JamesNK JamesNK deleted the jamesnk/remove-unsupported-scenario branch November 5, 2024 10:18
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Nov 5, 2024
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quarantine Http2RequestTests.GET_RequestReturnsLargeData_GracefulShutdownDuringRequest_RequestGracefullyCompletes
2 participants