Resurrect Blazor VSIX #6779

rynowak · 2019-01-16T23:51:25Z

dat [WIP] tho

SteveSandersonMS

I see it's a WIP but everything here looks plausible and I'm sure you'll be doing what's needed. Please feel free to ping me again if you want any further review.

src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj

The text-view-listener was the only thing here and it's not needed anymore now that these features are build into our main VS payload. We won't have any more code to put in this project because it's this VSIX is pretty temporary.

We don't need this reference, and it's got some breaking changes between 15 and 16 - rahter then mess with nuget sources for vs16 packages, I'm just going to drop the dependency

rynowak · 2019-01-24T00:09:25Z

It looks like this builds now, so we should be unblocked once the branch is open once again.

natemcmaster · 2019-01-24T02:00:41Z

Is this something that needs to ship with Preview 2? If so, I'm okay if we merge now.

rynowak · 2019-01-24T19:06:59Z

@mkArtakMSFT - want to stamp an approval on this one? We plan to ship this OOB when we ship preview 2 - there's no overlap between this thing and the in the box stuff.

mkArtakMSFT

Looks completely isolated to the BlazorExtension. Good to go.

rynowak · 2019-01-24T22:16:35Z

@mkArtakMSFT - are you able to override the checks? these tests are super unrelated because there are no tests for this

natemcmaster · 2019-01-24T22:25:15Z

I believe the test failure you're seeing is a fix that @halter73 is working on fixing in #6994, which we want to consume for 3.0 Preview 2 . cc @muratg

2019-01-23T21:28:13.8104873Z   Failed   RunIndividualTestCase(testCase: http2/6.2/1, HTTPS:True, Sends a HEADERS frame without the END_HEADERS flag, and a PRIORITY frame)
2019-01-23T21:28:13.8106190Z   Error Message:
2019-01-23T21:28:13.8107098Z    System.TimeoutException : h2spec didn't exit within 30 seconds.
2019-01-23T21:28:13.8108001Z   Stack Trace:
2019-01-23T21:28:13.8108928Z      at Interop.FunctionalTests.H2SpecCommands.RunTest(String testId, Int32 port, Boolean https, ILogger logger) in /_/src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecCommands.cs:line 230
2019-01-23T21:28:13.8109897Z      at Interop.FunctionalTests.H2SpecTests.RunIndividualTestCase(H2SpecTestCase testCase) in /_/src/Servers/Kestrel/test/Interop.FunctionalTests/H2SpecTests.cs:line 53
2019-01-23T21:28:13.8110724Z   --- End of stack trace from previous location where exception was thrown ---
2019-01-23T21:28:13.8118861Z   Standard Output Messages:
2019-01-23T21:28:13.8120300Z    | [0.023s] TestLifetime Information: Starting test RunIndividualTestCase-http2/6.2/1, HTTPS:True, Sends a HEADERS frame without the END_HEADERS flag, and a PRIORITY frame at 2019-01-23T21:27:43
2019-01-23T21:28:13.8121695Z    | [0.024s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting starting
2019-01-23T21:28:13.8122308Z    | [0.043s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting started
2019-01-23T21:28:13.8122730Z    | [0.043s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Loaded hosting startup assembly Interop.FunctionalTests
2019-01-23T21:28:13.8123019Z    | [0.112s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLK1F68PGRI5" started.
2019-01-23T21:28:13.8123569Z    | [0.135s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" sending SETTINGS frame for stream ID 0 with length 18 and flags NONE
2019-01-23T21:28:13.8123952Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" sending WINDOW_UPDATE frame for stream ID 0 with length 4 and flags 0x0
2019-01-23T21:28:13.8124275Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" received SETTINGS frame for stream ID 0 with length 6 and flags NONE
2019-01-23T21:28:13.8124597Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" sending SETTINGS frame for stream ID 0 with length 0 and flags ACK
2019-01-23T21:28:13.8124926Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" received SETTINGS frame for stream ID 0 with length 0 and flags ACK
2019-01-23T21:28:13.8125640Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" received HEADERS frame for stream ID 1 with length 16 and flags NONE
2019-01-23T21:28:13.8125966Z    | [0.136s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" received PRIORITY frame for stream ID 1 with length 5 and flags 0x0
2019-01-23T21:28:13.8126268Z    | [0.137s] Microsoft.AspNetCore.Server.Kestrel Information: Connection id "0HLK1F68PGRI5": HTTP/2 connection error.
2019-01-23T21:28:13.8126608Z    | Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2.Http2ConnectionErrorException: HTTP/2 connection error (PROTOCOL_ERROR): The client sent a PRIORITY frame to stream ID 1 before signaling of the header block for stream ID 1.
2019-01-23T21:28:13.8127222Z    |    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2.Http2Connection.ProcessPriorityFrameAsync() in /_/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs:line 594
2019-01-23T21:28:13.8127645Z    |    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2.Http2Connection.ProcessFrameAsync[TContext](IHttpApplication`1 application, ReadOnlySequence`1 payload) in /_/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs:line 410
2019-01-23T21:28:13.8128078Z    |    at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2.Http2Connection.ProcessRequestsAsync[TContext](IHttpApplication`1 application) in /_/src/Servers/Kestrel/Core/src/Internal/Http2/Http2Connection.cs:line 306
2019-01-23T21:28:13.8128430Z    | [0.137s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLK1F68PGRI5" is closed. The last processed stream ID was 1.
2019-01-23T21:28:13.8128756Z    | [0.137s] Microsoft.AspNetCore.Server.Kestrel Trace: Connection id "0HLK1F68PGRI5" sending GOAWAY frame for stream ID 0 with length 8 and flags 0x0
2019-01-23T21:28:13.8129093Z    | [0.137s] Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets Debug: Connection id "0HLK1F68PGRI5" sending FIN because: "The Socket transport's send loop completed gracefully."
2019-01-23T21:28:13.8129398Z    | [0.138s] Microsoft.AspNetCore.Server.Kestrel Debug: Connection id "0HLK1F68PGRI5" stopped.
2019-01-23T21:28:13.8129663Z    | [30.066s] Microsoft.AspNetCore.Hosting.Internal.WebHost Debug: Hosting shutdown
2019-01-23T21:28:13.8129975Z    | [30.067s] TestLifetime Information: Finished test RunIndividualTestCase-http2/6.2/1, HTTPS:True, Sends

rynowak requested review from natemcmaster and SteveSandersonMS as code owners January 16, 2019 23:51

SteveSandersonMS approved these changes Jan 17, 2019

View reviewed changes

rynowak force-pushed the rynowak/blazor-vsix branch from d67635c to c4a754c Compare January 17, 2019 02:14

natemcmaster reviewed Jan 17, 2019

View reviewed changes

src/Components/Blazor/BlazorExtension/src/Microsoft.VisualStudio.BlazorExtension.csproj Outdated Show resolved Hide resolved

natemcmaster approved these changes Jan 17, 2019

View reviewed changes

rynowak force-pushed the rynowak/blazor-vsix branch from adc9cb3 to cb0deb6 Compare January 18, 2019 02:13

Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Jan 18, 2019

rynowak force-pushed the rynowak/blazor-vsix branch 3 times, most recently from 9ec4ff2 to cd97f80 Compare January 19, 2019 01:53

rynowak added 13 commits January 23, 2019 10:38

Remove Blazor.LanguageServices

3821e2b

The text-view-listener was the only thing here and it's not needed anymore now that these features are build into our main VS payload. We won't have any more code to put in this project because it's this VSIX is pretty temporary.

Remove reference to ProjectSystem

2a7ba50

We don't need this reference, and it's got some breaking changes between 15 and 16 - rahter then mess with nuget sources for vs16 packages, I'm just going to drop the dependency

Remove unused cruft

7ec3c7f

Target net472

de30dd8

Add Blazor VSIX to build

bdf8772

Add Extension to .sln

9470ee4

Use AsyncPackage

5d181f0

Update and streamline references

39a137a

Update manifest for 16.0

23dab10

Pack Templates before building VSIX

468604e

Fix version of templates

d4b4e10

[WIP] get templates working

5dbc622

Fix VSIX version

16bcf97

rynowak force-pushed the rynowak/blazor-vsix branch from cd97f80 to 9a4d8f7 Compare January 23, 2019 18:38

dont pack

c9a0d55

rynowak force-pushed the rynowak/blazor-vsix branch from 9a4d8f7 to c9a0d55 Compare January 23, 2019 20:49

rynowak changed the title ~~[WIP] Resurrect Blazor VSIX~~ Resurrect Blazor VSIX Jan 24, 2019

mkArtakMSFT approved these changes Jan 24, 2019

View reviewed changes

natemcmaster merged commit f0fc598 into master Jan 24, 2019

natemcmaster deleted the rynowak/blazor-vsix branch January 24, 2019 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resurrect Blazor VSIX #6779

Resurrect Blazor VSIX #6779

rynowak commented Jan 16, 2019

Uh oh!

SteveSandersonMS left a comment

Uh oh!

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

natemcmaster commented Jan 24, 2019

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

mkArtakMSFT left a comment

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

natemcmaster commented Jan 24, 2019 •

edited

Loading

Uh oh!

Uh oh!

Resurrect Blazor VSIX #6779

Resurrect Blazor VSIX #6779

Conversation

rynowak commented Jan 16, 2019

Uh oh!

SteveSandersonMS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

natemcmaster commented Jan 24, 2019

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

mkArtakMSFT left a comment

Choose a reason for hiding this comment

Uh oh!

rynowak commented Jan 24, 2019

Uh oh!

natemcmaster commented Jan 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

natemcmaster commented Jan 24, 2019 •

edited

Loading