Fail ComplexTypeModelBinder after CanCreateModel(...) in some cases
#6793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rynowak this is a suggestion for the bug we were discussing today WIP because I haven't added applicable tests nor updated one existing test that now fails (because the relevant validation is not done anymore -- the container is now |
rynowak
reviewed
Jan 17, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ComplexTypeModelBinder.cs
Outdated
Show resolved
Hide resolved
rynowak
reviewed
Jan 17, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ComplexTypeModelBinder.cs
Show resolved
Hide resolved
rynowak
reviewed
Jan 17, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ComplexTypeModelBinder.cs
Show resolved
Hide resolved
rynowak
reviewed
Jan 17, 2019
src/Mvc/src/Microsoft.AspNetCore.Mvc.Core/ModelBinding/Binders/ComplexTypeModelBinder.cs
Outdated
Show resolved
Hide resolved
rynowak
requested changes
Jan 17, 2019
Eilon
added
the
area-mvc
dougbu
force-pushed
the
dougbu/fail.complexmodelbinder.4802
branch
from
6958d26 to
02a8adc
Compare
|
🆙📅 |
dougbu
changed the title
ComplexTypeModelBinder after CanCreateModel(...) in some casesComplexTypeModelBinder after CanCreateModel(...) in some cases
dougbu
force-pushed
the
dougbu/fail.complexmodelbinder.4802
branch
from
02a8adc to
2682923
Compare
|
🆙📅 to cover #6616 scenario as well |
dougbu
commented
Jan 31, 2019
|
|
||
| var binder = new Mock<TestableComplexTypeModelBinder>() { CallBase = true }; | ||
| var binder = new Mock<TestableComplexTypeModelBinder>(binders) { CallBase = true }; |
There was a problem hiding this comment.
Required now because of the check at https://github.com/aspnet/AspNetCore/pull/6793/files#diff-44e4a40c4a5c7c29dd5892f664b5b362R142 (Didn't like the idea of adding another protected virtual method for two tests.)
|
/cc @pranavkm |
- cover #6616 cases nit: improve added test name
dougbu
force-pushed
the
dougbu/fail.complexmodelbinder.4802
branch
from
2682923 to
9630151
Compare
dougbu
commented
Feb 4, 2019
|
|
||
| Assert.True(modelState.IsValid); | ||
| } | ||
|
|
||
| private static void SetJsonBodyContent(HttpRequest request, string content) |
There was a problem hiding this comment.
Rewritten to allow method to be called more than once and to use separate body and part headers
|
Bump @rynowak |
rynowak
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.