Skip to content

Move generic webhost log output, enable in templates #6814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2019
Merged

Move generic webhost log output, enable in templates #6814

merged 1 commit into from
Jan 17, 2019

Conversation

Tratcher
Copy link
Member

#6449, combines with dotnet/extensions#964 to enable startup and shutdown logs in production.

Logs (without the Extensions changes):

info: Microsoft.Hosting.Lifetime[0]
      Now listening on: http://localhost:5000
info: Microsoft.Hosting.Lifetime[0]
      Now listening on: https://localhost:5001
info: Microsoft.Extensions.Hosting.Host[0]
      Application started. Press Ctrl+C to shut down.
info: Microsoft.Extensions.Hosting.Host[0]
      Hosting environment: Production
info: Microsoft.Extensions.Hosting.Host[0]
      Content root path: D:\github\AspNetCore\src\Hosting\samples\GenericWebHost\bin\Debug\netcoreapp3.0

@Tratcher Tratcher added this to the 3.0.0-preview2 milestone Jan 17, 2019
@Tratcher Tratcher self-assigned this Jan 17, 2019
ryanbrandenburg
ryanbrandenburg approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: from the Templating end.

@Tratcher Tratcher merged commit 9c017cd into master Jan 17, 2019
@Tratcher Tratcher deleted the tratcher/log branch January 17, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@glennc glennc Awaiting requested review from glennc

Assignees

@Tratcher Tratcher

Labels
None yet
Projects
None yet
Milestone
3.0.0-preview2
Development

Successfully merging this pull request may close these issues.
3 participants
@Tratcher @davidfowl @ryanbrandenburg