Skip to content

Kill processes after completing build and before publishing test results or artifacts #7228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 5, 2019
Merged

Kill processes after completing build and before publishing test results or artifacts #7228

merged 4 commits into from
Feb 5, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Feb 4, 2019 •
edited
Loading

  • aspnet/AspNetCore-Internal#1735
  • port dotnet/extensions@e2bb8ac1a0 fix into this repo
    • change ci-official.yml and default-build.yml instead of azure-pipelines.yml

@dougbu
Kill processes after completing build and before publishing test resu…
35f4208 
…lts or artifacts

- aspnet/AspNetCore-Internal#1735
- port dotnet/extensions@e2bb8ac1a0 fix into this repo
  - change `ci-official.yml` and `default-build.yml` instead of `azure-pipelines.yml`
@dougbu dougbu force-pushed the dougbu/kill.processes.1735 branch from f8d2591 to 35f4208 Compare February 4, 2019 03:18
@natemcmaster
Copy link
Contributor

We should do this in ci.yml and delete ci-official.yml from 2.x branches. It's not used and I removed that file from the master branch in favor of ci.yml.

@dougbu
Copy link
Contributor Author

dougbu commented Feb 4, 2019

We should do this in ci.yml

ci.yml doesn't even contain buildScript settings at the moment. Alright to remove ci-official.yml and stick with my changes to the default-build.yml template?

@ryanbrandenburg
Copy link
Contributor

The OOM error on linux seems unrelated. @natemcmaster is that tracked somewhere? I seem to remember you mentioning something similar.

ryanbrandenburg
ryanbrandenburg reviewed Feb 4, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code seems fine. I'll be happy when @natemcmaster is happy.

@dougbu
Copy link
Contributor Author

dougbu commented Feb 4, 2019

The OOM error on linux seems unrelated.

Agreed, I copied from the wrong tab. The bug related to this PR is #4067.

@natemcmaster
Copy link
Contributor

remove ci-official.yml and stick with my changes to the default-build.yml template?

Yes sounds good to me

@dougbu
Copy link
Contributor Author

dougbu commented Feb 4, 2019 •
edited
Loading

Actually, aspnet/AspNetCore-Internal#1735 is also correct. That's about file locking caused by msbuild processes that were still running when attempting to publish artifacts.

@dougbu
Copy link
Contributor Author

dougbu commented Feb 4, 2019

And, #4067 is incorrect. That one is addressed in my #7231 PR.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 4, 2019
natemcmaster
natemcmaster reviewed Feb 4, 2019
View reviewed changes
eng/scripts/KillProcesses.ps1 Outdated
@@ -0,0 +1,16 @@
#!/usr/bin/env pwsh -c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still don't think this is useful to run on *nix. taskkill is not an available command, so this script will never work on anything but Windows (which doesn't interpret the shebang)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 you've convinced me 😺 I'll remove this and do chmod -x on the file.

natemcmaster
natemcmaster reviewed Feb 4, 2019
View reviewed changes
dougbu
dougbu commented Feb 4, 2019
View reviewed changes
Copy link
Contributor Author

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once this goes through, I'll run through the aspnet/Extensions branches to make KillProcesses.ps1 consistent.

eng/scripts/KillProcesses.ps1 Outdated
@@ -0,0 +1,16 @@
#!/usr/bin/env pwsh -c
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗 you've convinced me 😺 I'll remove this and do chmod -x on the file.

@dougbu dougbu merged commit f5ca141 into release/2.1 Feb 5, 2019
@dougbu dougbu deleted the dougbu/kill.processes.1735 branch February 5, 2019 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg left review comments

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @natemcmaster @ryanbrandenburg @Eilon