[Backport] Add CancelInvocation support to MsgPack in TS client #7404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Eilon could you bar-check this one please? |
|
mikaelm12
added
Servicing-consider
I'm pretty sure that was an off by one. I just updated it to consider.
This is correct. |
|
Cool. Can send shiproom mail for it. BTW I recommend updating the shiproom template to indicate it ships as OOB because it's an NPM package, not NuGet. |
We try not to do that and build/ship at the same time the nupkgs do. |
|
Yeah I get we ship as part of the build, and I don't want to do a one-off, but it's less scary when it's not in a NUPKG 😄 |
|
Thanks! (It was my mistake to mislabel this.) I'll get this to the shiproom tomorrow. |
halter73
approved these changes
Feb 13, 2019
vivmishra
added
Servicing-approved
|
Approved for 2.2.3 |
muratg
approved these changes
Feb 14, 2019
mikaelm12
approved these changes
Feb 14, 2019
|
/azp run AspNetCore-ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@dougbu FYI this is in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #7224
Issue #7157
Description
The @aspnet/signalr-protocols-msgpack addition to the Javascript client would throw when sending a new message that was added to the SignalR protocol in the 2.2 release. This change adds the serializing for that new message so it no longer throws for correct behavior.
Customer Impact
Customers will no longer get exceptions for using this correct behavior.
Regression?
None, this is a new feature that was added and was missed getting added to the @aspnet/signalr-protocols-msgpack npm package.
Risk
Very low, adding a serialized response on the client when it would incorrectly throw before.
cc @muratg