Skip to content

More efficient preface parsing #7406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 9, 2019
Merged

More efficient preface parsing #7406

merged 1 commit into from
Feb 9, 2019

Conversation

davidfowl
Copy link
Member

  • Slice before turning the buffer into a Span
  • Use SequenceEqual instead of a loop

@davidfowl
More efficient preface parsing
64d5df9 
- Slice before turning the buffer into a Span
- Use SequenceEqual instead of a loop
@davidfowl davidfowl requested a review from jkotalik as a code owner February 9, 2019 02:38
@davidfowl davidfowl merged commit 8f49bdf into master Feb 9, 2019
@davidfowl davidfowl deleted the davidfowl/preface-parse branch March 4, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tratcher Tratcher Tratcher approved these changes

@halter73 halter73 Awaiting requested review from halter73

@pakrym pakrym Awaiting requested review from pakrym

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidfowl @Tratcher