-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Replace custom targets for generating assembly attributes and source control info by using SDK features #7504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…control info by using SDK features
…ect types which support source link
…by project types which support source link
…source control info by using SDK features
…es and source control info by using SDK features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Components changes look good.
…ported by project types which support source link
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Questions, questions…
</PropertyGroup> | ||
|
||
<PropertyGroup Condition=" '$(OfficialBuildId)' != '' AND '$(BuildNumberSuffix)' == '' "> | ||
<PropertyGroup Condition=" '$(OfficialBuildId)' != '' "> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean we can only build -t000
packages locally now? Ugh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still override whatever you want, e.g. build.cmd /p:IsOfficialBuild=true
, build.cmd /p:BuildNumberSuffix=1234
, etc. This change is mean to remove the part of this code that uses TeamCity environment variables.
<!-- Additional assembly attributes are already configured to include the source revision ID. --> | ||
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion> | ||
|
||
<DisableSourceLink Condition="'$(MSBuildProjectExtension)' == '.zipproj' OR '$(MSBuildProjectExtension)' == '.debproj' OR '$(MSBuildProjectExtension)' == '.rpmproj'">true</DisableSourceLink> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems odd to me that *.proj
, *.javaproj
, *.npmproj
, *.pkgproj
, *.shfxproj
, and *.vcxproj
aren't included in this condition. Why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The project types listed were excluded because adding the PackageReference causes NuGet to fail because they don't import Microsoft.Common.targets. We probably could disable source link on javaproj/npmproj, but I left them on enabled because they weren't causing issues.
…only imported by project types which support source link
Part of aspnet/BuildTools#618 and preparation for #7280
Changes: