Add negotiation response support #7675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halter73
requested changes
Feb 19, 2019
mikaelm12
reviewed
Feb 19, 2019
| // TODO: check available transports | ||
| if (!foundWebsockets) | ||
| { | ||
| return pplx::task_from_exception<void>(signalr_exception(_XPLATSTR("WebSockets is the only supported transport currently"))); |
There was a problem hiding this comment.
Maybe prefix this with the regular message of "No compatible transports found on the server"
src/SignalR/clients/cpp/test/signalrclienttests/connection_impl_tests.cpp
Show resolved
Hide resolved
src/SignalR/clients/cpp/test/signalrclienttests/connection_impl_tests.cpp
Show resolved
Hide resolved
BrennanConroy
force-pushed
the
brecon/negotiate
branch
from
77684a2 to
bae2832
Compare
mikaelm12
reviewed
Feb 20, 2019
| { | ||
| auto connection = weak_connection.lock(); | ||
| if (!connection) | ||
| return pplx::task_from_exception<negotiation_response>(_XPLATSTR("connection no longer exists")); |
There was a problem hiding this comment.
Capitalization and periods for the exception messages
There was a problem hiding this comment.
I'll do an exception/log message pass in a different PR as there are a lot that need to be updated.
Updated the giant list with log and exception messages as an item.
halter73
approved these changes
Feb 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including support for the Azure SignalR Server (ASRS)!
Fixes #7623 too