Skip to content

Fix SHA calculations #7804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 21, 2019
Merged

Fix SHA calculations #7804

merged 2 commits into from
Feb 21, 2019

Conversation

ryanbrandenburg
Copy link
Contributor

Fixes aspnet/AspNetCore-Internal#1833.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Feb 21, 2019
@ryanbrandenburg ryanbrandenburg marked this pull request as ready for review February 21, 2019 22:38
natemcmaster
natemcmaster approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Get manager approval too as this targets release/2.2. Likely won't need shiproom approval because it's a test-only change.

cc @mkArtakMSFT @Eilon

@ryanbrandenburg
Copy link
Contributor Author

Didn't occur to me that I'd need approval since it's a test only change.

@ryanbrandenburg ryanbrandenburg merged commit ae0c3dc into release/2.2 Feb 21, 2019
@ryanbrandenburg ryanbrandenburg deleted the rybrande/Subresource22 branch February 21, 2019 23:19
@ryanbrandenburg
Copy link
Contributor Author

Got approval from both @mkArtakMSFT and @Eilon offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanbrandenburg @natemcmaster @Eilon