Skip to content

Clarify ExternalLoginInfo displayName doc comment #7833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2019
Merged

Clarify ExternalLoginInfo displayName doc comment #7833

merged 1 commit into from
Feb 27, 2019

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Feb 22, 2019

@HaoK HaoK requested a review from blowdart February 22, 2019 00:20
@Eilon Eilon added the area-identity Includes: Identity and providers label Feb 22, 2019
blowdart
blowdart approved these changes Feb 26, 2019
View reviewed changes
Copy link
Contributor

@blowdart blowdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HaoK HaoK merged commit 07dad89 into master Feb 27, 2019
@HaoK HaoK deleted the HaoK-doc branch February 27, 2019 23:02
@osagga
Copy link

osagga commented Oct 7, 2020

@HaoK #6712 states that the doc comment is not correct in both ExternalLoginInfo and UserLoginInfo, is there a reason that this PR only addresses the issue in ExternalLoginInfo? Shouldn't a fix to the issue also address the same issue here

aspnetcore/src/Identity/Extensions.Core/src/UserLoginInfo.cs

Line 16 in 9939b33

/// <param name="displayName">The display name for this user provided by the login provider.</param>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blowdart blowdart blowdart approved these changes

Assignees
No one assigned
Labels
area-identity Includes: Identity and providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent DisplayName CTOR/property documented intent within ExternalLoginInfo and UserLoginInfo
4 participants
@HaoK @osagga @blowdart @Eilon