Skip to content

Update template icons #7931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2019
Merged

Update template icons #7931

merged 2 commits into from
Mar 8, 2019

Conversation

JunTaoLuo
Copy link
Contributor

Updated with latest icons. @SteveSandersonMS do you know where the templates for Blazor are?

cc @muratg @Eilon for Ask Mode

@JunTaoLuo
Copy link
Contributor Author

I think this is low risk enough for preview 3 but it's not a critical fix and could potentially wait for preview 4

@JunTaoLuo
Copy link
Contributor Author

@SteveSandersonMS I found the Blazor templates.

@JunTaoLuo
Copy link
Contributor Author

JunTaoLuo commented Feb 26, 2019 •
edited
Loading

Apparently there are potential CLA requirements that are not met fort the gRPC icons. Consider this PR blocked and therefor probably not going to go in to preview 3

@JunTaoLuo JunTaoLuo added this to the 3.0.0-preview4 milestone Feb 26, 2019
@JunTaoLuo JunTaoLuo changed the base branch from release/3.0-preview3 to master February 26, 2019 00:38
muratg
muratg reviewed Feb 26, 2019
View reviewed changes
Copy link
Contributor

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should wait for preview4. Build folks are trying to get a build out ASAP.

@shirhatti
Copy link
Contributor

@JunTaoLuo See https://github.com/cncf/artwork/blob/master/LICENSE.md

Based on my reading, we can't use the gRPC logo. I'll reach to CELA

@Eilon
Copy link
Contributor

Eilon commented Feb 26, 2019

@shirhatti - indeed, please follow up with CELA.

@Eilon Eilon added the area-grpc Includes: GRPC wire-up, templates label Feb 26, 2019
@JunTaoLuo
Copy link
Contributor Author

Updated to latest gRPC icon. This is ready to be merged.

@Tratcher
Copy link
Member

Tratcher commented Mar 7, 2019

@aspnet/brt

Microsoft.AspNetCore.Mvc.FunctionalTests.TempDataInCookiesUsingCookieConsentTest.CookieTempDataProviderCookie_SetInResponse_OnGrantingConsent
System.InvalidOperationException : 'Serializing TempDataDictionary' requires a reference to 'Microsoft.AspNetCore.Mvc.NewtonsoftJson'. Configure your application by adding a reference to the 'Microsoft.AspNetCore.Mvc.NewtonsoftJson' package and calling 'IMvcBuilder.AddNewtonsoftJson' inside the call to 'ConfigureServices(...)' in the application startup code.

@analogrelay
Copy link
Contributor

Filed #8285

@JunTaoLuo JunTaoLuo merged commit 2cf67cb into master Mar 8, 2019
@JunTaoLuo JunTaoLuo deleted the johluo/icons branch March 8, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratg muratg muratg left review comments

@Tratcher Tratcher Tratcher approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@danroth27 danroth27 Awaiting requested review from danroth27

@shirhatti shirhatti Awaiting requested review from shirhatti

@SteveSandersonMS SteveSandersonMS Awaiting requested review from SteveSandersonMS

@dougbu dougbu Awaiting requested review from dougbu

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-grpc Includes: GRPC wire-up, templates
Projects
None yet
Milestone
3.0.0-preview4
Development

Successfully merging this pull request may close these issues.
7 participants
@JunTaoLuo @shirhatti @Eilon @Tratcher @analogrelay @muratg @ryanbrandenburg