-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Remove bad IsCompleted Check #7933
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/Servers/Kestrel/test/InMemory.FunctionalTests/Http2/Http2StreamTests.cs
Outdated
Show resolved
Hide resolved
Test failure: https://github.com/aspnet/AspNetCore-Internal/issues/1879. Will investigate once I have time. |
If this isn't any more difficult than deflakifying the tests, I definitely recommend it. |
Mac agent having issuse 😢 @dougbu @ryanbrandenburg thoughts? |
Yeah its in a bad way #7978 |
Test only issue. There is a check for IsCompleted that is super flaky... had a brain fart here.