Skip to content

Remove bad IsCompleted Check #7933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 27, 2019
Merged

Remove bad IsCompleted Check #7933

merged 4 commits into from
Feb 27, 2019

Conversation

jkotalik
Copy link
Contributor

Test only issue. There is a check for IsCompleted that is super flaky... had a brain fart here.

@jkotalik jkotalik changed the title Remove bad IsCompletedCheck Remove bad IsCompleted Check Feb 26, 2019
@jkotalik
Copy link
Contributor Author

@jkotalik
Copy link
Contributor Author

Test failure: https://github.com/aspnet/AspNetCore-Internal/issues/1879. Will investigate once I have time.

@halter73
Copy link
Member

As potentially an optimization for Http2, we can Complete the pipe when we received Content-Length amount of data. I don't believe I see us doing that today.

If this isn't any more difficult than deflakifying the tests, I definitely recommend it.

@jkotalik
Copy link
Contributor Author

@halter73 @Tratcher updated to optimize content length requests for Http2. Let's get this in sooner than later as the test is very flaky.

@jkotalik
Copy link
Contributor Author

Mac agent having issuse 😢 @dougbu @ryanbrandenburg thoughts?

@jkotalik jkotalik merged commit bbe4a9d into master Feb 27, 2019
@BrennanConroy BrennanConroy deleted the jkotalik/removeBadCheck branch February 27, 2019 02:30
@benaadams
Copy link
Member

Mac agent having issuse 😢

Yeah its in a bad way #7978

@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants