Skip to content

Improve NullHtmlEncoder perf #7987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 5, 2019
Merged

Improve NullHtmlEncoder perf #7987

merged 5 commits into from
Mar 5, 2019

Conversation

sebastienros
Copy link
Member

It's used anywhere IHtmlContent is rendered.

|                      Method |      Mean |     Error |    StdDev | Ratio | Gen 0/1k Op | Gen 1/1k Op | Gen 2/1k Op | Allocated Memory/Op |
|---------------------------- |----------:|----------:|----------:|------:|------------:|------------:|------------:|--------------------:|
|           MvcNullHtmlEncode | 0.9833 ns | 0.0121 ns | 0.0101 ns |  1.00 |           - |           - |           - |                   - |
| InlinedBetterNullHtmlEncode | 0.2979 ns | 0.0147 ns | 0.0138 ns |  0.30 |           - |           - |           - |                   - |

davidfowl
davidfowl reviewed Feb 27, 2019
View reviewed changes
@davidfowl davidfowl added the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Feb 27, 2019
@mkArtak
Copy link
Contributor

mkArtak commented Feb 28, 2019

Addresses #8019

@mkArtak
Copy link
Contributor

mkArtak commented Feb 28, 2019

@sebastienros, we track the labels on the issues, so filed one and referenced for that purpose.

@mkArtakMSFT mkArtakMSFT removed the breaking-change This issue / pr will introduce a breaking change, when resolved / merged. label Feb 28, 2019
@pranavkm pranavkm added breaking-change This issue / pr will introduce a breaking change, when resolved / merged. area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates labels Feb 28, 2019
davidfowl
davidfowl reviewed Feb 28, 2019
View reviewed changes
@analogrelay
Copy link
Contributor

@sebastienros Helix failures should be resolved by a rebase, please rebase asap.

@sebastienros sebastienros force-pushed the sebros/nullhtmlencoder branch from 419bbe0 to 2759606 Compare March 1, 2019 19:22
@analogrelay
Copy link
Contributor

analogrelay commented Mar 1, 2019 •
edited
Loading

https://github.com/aspnet/AspNetCore-Internal/issues/1898 - Build timeout :(

Also: https://github.com/aspnet/AspNetCore/issues/7265

@analogrelay analogrelay mentioned this pull request Mar 1, 2019
Merged
@sebastienros sebastienros reopened this Mar 2, 2019
analogrelay added a commit that referenced this pull request Mar 2, 2019
@analogrelay
Skip flaky clientcert test in Kestrel (#8112)
6e8a9f6 
related #7265

flaked out in #7987
@pranavkm pranavkm merged commit b90220a into master Mar 5, 2019
@pranavkm pranavkm deleted the sebros/nullhtmlencoder branch March 5, 2019 22:41
@pranavkm pranavkm mentioned this pull request Mar 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkArtakMSFT mkArtakMSFT mkArtakMSFT left review comments

@davidfowl davidfowl davidfowl approved these changes

@pranavkm pranavkm pranavkm approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates breaking-change This issue / pr will introduce a breaking change, when resolved / merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sebastienros @mkArtak @analogrelay @davidfowl @pranavkm @mkArtakMSFT