Restore testassets during build to prevent timeouts #8038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
approved these changes
Feb 28, 2019
| @@ -32,6 +32,7 @@ | |||
| <Reference Include="Microsoft.AspNetCore.Razor.Design" /> | |||
| <Reference Include="rzc" /> | |||
| <Reference Include="Microsoft.AspNetCore.Razor.Test.MvcShim.ClassLib" /> | |||
| <ProjectReference Include="..\testassets\RestoreTestProjects\RestoreTestProjects.csproj" ReferenceOutputAssembly="false" /> | |||
pranavkm
force-pushed
the
prkrishn/restore-early
branch
from
de8eaf7 to
1d170a3
Compare
|
@mkArtakMSFT what's the process for making a 2.1 \ 2.2 change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/aspnet/AspNetCore-Internal/issues/1695
We did something similar in master (See dotnet/razor@7f49b97). This back-ports the change to improve test reliability. There are some packages like FSharp.Core that currently exclusively get restored during test run.