Skip to content

Check HasStarted before calling Flush/Start in StartAsync #8041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 1, 2019
Merged

Check HasStarted before calling Flush/Start in StartAsync #8041

merged 2 commits into from
Mar 1, 2019

Conversation

jkotalik
Copy link
Contributor

Fixes #7778

@jkotalik jkotalik requested review from JamesNK and Tratcher February 28, 2019 19:58
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 1, 2019

Test failures are also filed here. Will be disabling AbortedStream_ResetsAndDrainsRequest_RefusesFramesAfterCooldownExpires as that test is very flaky.

@jkotalik jkotalik merged commit 5fd53d9 into master Mar 1, 2019
@natemcmaster natemcmaster deleted the jkotalik/StartAsyncFast branch May 3, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@davidfowl davidfowl davidfowl approved these changes

@JamesNK JamesNK JamesNK approved these changes

@Tratcher Tratcher Tratcher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkotalik @halter73 @davidfowl @JamesNK @Tratcher