Add some additional logging to ErrorPageMiddlewareWebSite #8049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeveloperExceptionMiddleware will log an error if rendering the exception page throws. The test failure in https://github.com/aspnet/AspNetCore-Internal/issues/1730 suggests that we encountered an error like so but do not have anything further to go by. This change adds logging to the test so we could identify possible issues
javiercn
reviewed
Mar 1, 2019
javiercn
reviewed
Mar 1, 2019
javiercn
approved these changes
Mar 1, 2019
Eilon
added
the
area-mvc
NTaylorMullen
approved these changes
Mar 1, 2019
dougbu
added a commit
to dotnet-maestro-bot/AspNetCore
that referenced
this pull request
Mar 18, 2019
- no-ops except for - Update PatchConfig.props (2835f85) - Add some additional logging to ErrorPageMiddlewareWebSite (dotnet#8049) (aka 1ca6202) - Put MVC's functional tests in a separate test group (dotnet#8118) (aka db3795b) - ignore the build queue (4f2a0ed) change because we're not hitting Linux resource issues in `master` branch - ignore baseline test changes (5661c41 and d2a4435) because they're not applicable in `master`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeveloperExceptionMiddleware will log an error if rendering the exception page
throws. The test failure in https://github.com/aspnet/AspNetCore-Internal/issues/1730
suggests that we encountered an error like so but do not have anything further to go by.
This change adds logging to the test so we could identify possible issues