Skip to content

Flake Finder #8088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Flake Finder #8088

wants to merge 1 commit into from

Conversation

analogrelay
Copy link
Contributor

A PR with no changes to help tease out flakiness in our PR builds.

cc @pakrym @dougbu @ryanbrandenburg

@analogrelay analogrelay force-pushed the anurse/flake-finder-1 branch from 2415a0a to bc40040 Compare March 1, 2019 18:17
@jkotalik
Copy link
Contributor

jkotalik commented Mar 1, 2019

Make more of these 😄

@analogrelay
Copy link
Contributor Author

Make more of these 😄

Don't want to overwhelm the queue, but I'll add some more... slowly :)

@analogrelay
Copy link
Contributor Author

Flakiness found! #8100

@analogrelay analogrelay force-pushed the anurse/flake-finder-1 branch from bc40040 to a165782 Compare March 1, 2019 21:59
@HaoK
Copy link
Member

HaoK commented Mar 1, 2019

Longer term, maybe what we should do is to just put them in their own little 'troll island' and run all the flaky tests together so they at least run, the upside of this is we can see just how flaky they are, and its also easier for people to look into them if they are still running (maybe we just have a permanent flaky-test-hell-branch that has an additional check that runs all the tests including the flaky ones so it doesn't make master PRs red)

@dougbu
Copy link
Contributor

dougbu commented Mar 1, 2019

Hmm… For example, could create a new xUnit.Net attribute that skips tests except when some environment variable is set to 1, true, True et cetera. A non-required (Helix?) job in every build could set the environment variable and otherwise do what it normally does.

@HaoK
Copy link
Member

HaoK commented Mar 1, 2019

Yeah we just need an additional [FlakyTest] badge of shame and can have it do the right things

@analogrelay
Copy link
Contributor Author

analogrelay commented Mar 1, 2019

I like it. It helps alleviate some of the concerns around skipping flaky tests immediately (rather than having them be investigated first).

@analogrelay
Copy link
Contributor Author

/azp run AspNetCore-helix-test

@analogrelay analogrelay closed this Mar 5, 2019
@analogrelay analogrelay deleted the anurse/flake-finder-1 branch March 5, 2019 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants