Skip to content

Skipping flaky test #8101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Skipping flaky test #8101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ public TempDataInCookiesTest(MvcTestFixture<BasicWebSite.StartupWithoutEndpointR

protected override HttpClient Client { get; }


[Theory]
[InlineData(ChunkingCookieManager.DefaultChunkSize)]
[InlineData(ChunkingCookieManager.DefaultChunkSize * 1.5)]
Expand Down
18 changes: 9 additions & 9 deletions src/Mvc/test/Mvc.FunctionalTests/TempDataTestBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public abstract class TempDataTestBase
{
protected abstract HttpClient Client { get; }

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task PersistsJustForNextRequest()
{
// Arrange
Expand Down Expand Up @@ -47,7 +47,7 @@ public async Task PersistsJustForNextRequest()
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task ViewRendersTempData()
{
// Arrange
Expand All @@ -66,7 +66,7 @@ public async Task ViewRendersTempData()
Assert.Equal("Foo", body);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task Redirect_RetainsTempData_EvenIfAccessed()
{
// Arrange
Expand Down Expand Up @@ -97,7 +97,7 @@ public async Task Redirect_RetainsTempData_EvenIfAccessed()
Assert.Equal("Foo", body);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task Peek_RetainsTempData()
{
// Arrange
Expand Down Expand Up @@ -130,7 +130,7 @@ public async Task Peek_RetainsTempData()
Assert.Equal("Foo", body);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task ValidTypes_RoundTripProperly()
{
// Arrange
Expand Down Expand Up @@ -162,7 +162,7 @@ public async Task ValidTypes_RoundTripProperly()
Assert.Equal($"Foo 10 3 10/10/2010 00:00:00 {testGuid.ToString()}", body);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task ResponseWrite_DoesNotCrashSaveTempDataFilter()
{
// Arrange
Expand All @@ -176,7 +176,7 @@ public async Task ResponseWrite_DoesNotCrashSaveTempDataFilter()
var response = await Client.GetAsync("/TempData/SetTempDataResponseWrite");
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task SetInActionResultExecution_AvailableForNextRequest()
{
// Arrange
Expand Down Expand Up @@ -207,7 +207,7 @@ public async Task SetInActionResultExecution_AvailableForNextRequest()
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task SaveTempDataFilter_DoesNotSaveTempData_OnUnhandledException()
{
// Arrange & Act
Expand All @@ -225,7 +225,7 @@ public async Task SaveTempDataFilter_DoesNotSaveTempData_OnUnhandledException()
Assert.Equal(HttpStatusCode.NoContent, response.StatusCode);
}

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore-Internal/issues/1803")]
public async Task SaveTempDataFilter_DoesNotSaveTempData_OnHandledExceptions()
{
// Arrange & Act
Expand Down