Adding logging to identify the issue in https://github.com/aspnet/AspNetCore-Internal/issues/1803 #8102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ajaybhargavb
approved these changes
Mar 1, 2019
| } | ||
|
|
||
| throw new Exception($"Expected exactly one instance of TempDataSerializer based on NewtonsoftJson, but found {tempDataSerializers.Count} instance(s):" + Environment.NewLine + builder); | ||
| } |
There was a problem hiding this comment.
If this fails, it might get reported as a new issue since the callstack will be different. You might need to watch for new incoming issues
There was a problem hiding this comment.
The plan is to not merge this in to master. Just re-running it here to help diagnose the issue
There was a problem hiding this comment.
Using a Draft PR might make that clearer (you can't go back to Draft now though so 🤷♂️)
There was a problem hiding this comment.
😿 I was actually planning on checking in before I checked in with you (🥁).
|
/azp run AspNetCore-ci |
Eilon
added
the
area-mvc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.