Skip to content

Update branding to 2.1.10 #8265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Update branding to 2.1.10 #8265

merged 2 commits into from
Mar 7, 2019

Conversation

dougbu
Copy link
Contributor

@dougbu dougbu commented Mar 7, 2019

No description provided.

@dougbu
Copy link
Contributor Author

dougbu commented Mar 7, 2019

@aspnet/brt looks like the following is another release/2.1 flaky test. May also be an off-by-one error 😈

  [xUnit.net 00:00:16.72]     LargeUpload(maxRequestBufferSize: 5242880, connectionAdapter: True, expectPause: True) [FAIL]
  Failed   LargeUpload(maxRequestBufferSize: 5242880, connectionAdapter: True, expectPause: True)
  Error Message:
   Assert.InRange() Failure
  Range:  (5238785 - 20971519)
  Actual: 20971520
  Stack Trace:
     at Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.MaxRequestBufferSizeTests.LargeUpload(Nullable`1 maxRequestBufferSize, Boolean connectionAdapter, Boolean expectPause) in /_/src/Servers/Kestrel/test/FunctionalTests/MaxRequestBufferSizeTests.cs:line 152
  --- End of stack trace from previous location where exception was thrown ---
  Test Run Failed.
  Results File: F:\vsagent\20\s\artifacts\logs\Sockets.FunctionalTest-netcoreapp2.1-20190306.64.trx
  
  Total tests: 601. Passed: 598. Failed: 1. Skipped: 2.
  Test execution time: 1.0567 Minutes
F:\vsagent\20\.dotnet\buildtools\korebuild\2.1.7-build-20190110.2\modules\vstest\module.targets(136,5): error : Test group Sockets.FunctionalTest/netcoreapp2.1 failed with exit code '1'. [F:\vsagent\20\.dotnet\buildtools\korebuild\2.1.7-build-20190110.2\KoreBuild.proj]

@dougbu dougbu merged commit e497f41 into release/2.1 Mar 7, 2019
@dougbu dougbu deleted the dougbu/branding.2.1.10 branch March 7, 2019 03:45
@dougbu dougbu added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Mar 7, 2019
@analogrelay
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants