Skip to content

Swap installer names #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

Swap installer names #8266

merged 1 commit into from
Mar 7, 2019

Conversation

jkotalik
Copy link
Contributor

@jkotalik jkotalik commented Mar 7, 2019

Fixes the windows hosting bundle build. The wrong variable was being set for each installer.

@jkotalik jkotalik requested a review from pakrym March 7, 2019 00:52
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 7, 2019

@muratg @shirhatti @Eilon let's figure out if/how we are going to deliver this to the preview3 hosting bundle.

@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 7, 2019

Fixes: #8249

@jkotalik jkotalik changed the base branch from master to release/3.0-preview3 March 7, 2019 16:06
@jkotalik jkotalik force-pushed the jkotalik/fixInstallers branch from 0131c83 to cbd1e46 Compare March 7, 2019 16:07
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 7, 2019

We decided we wouldn't fix this in preview3. Changing to master.

@jkotalik jkotalik changed the base branch from release/3.0-preview3 to master March 7, 2019 21:21
@jkotalik
Copy link
Contributor Author

jkotalik commented Mar 7, 2019

@mikaelm12 another failure

  com.microsoft.signalr.HubConnectionTest > TransportAllUsesLongPollingWhenServerOnlySupportLongPolling() FAILED
      java.lang.RuntimeException at HubConnectionTest.java:1518
          Caused by: java.lang.Exception at HubConnectionTest.java:1518

@jkotalik jkotalik merged commit c79b241 into master Mar 7, 2019
@jkotalik jkotalik deleted the jkotalik/fixInstallers branch March 7, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym pakrym pakrym approved these changes

@muratg muratg muratg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkotalik @pakrym @muratg