Skip to content

even more skipping! #8286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2019
Merged

even more skipping! #8286

merged 1 commit into from
Mar 11, 2019

Conversation

analogrelay
Copy link
Contributor

analogrelay
analogrelay commented Mar 7, 2019
View reviewed changes
src/Mvc/test/Mvc.FunctionalTests/TempDataInCookiesUsingCookieConsentTest.cs Outdated
@@ -28,7 +28,7 @@ public class TempDataInCookiesUsingCookieConsentTest
private static void ConfigureWebHostBuilder(IWebHostBuilder builder) =>
builder.UseStartup<BasicWebSite.StartupWithCookieTempDataProviderAndCookieConsent>();

[Fact]
[Fact(Skip = "https://github.com/aspnet/AspNetCore/issues/8285")]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need reviewer for MVC TempData test skip cc @Eilon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkArtakMSFT ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just got done skipping these. 8aa0218

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

ಠ_ಠ

@Eilon Eilon added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-servers labels Mar 7, 2019
@analogrelay analogrelay force-pushed the anurse/skipathon-part-2 branch from f07bbcc to e69ebc8 Compare March 8, 2019 17:59
@analogrelay
Copy link
Contributor Author

More mac timeouts...

@analogrelay analogrelay merged commit c9c2bf6 into master Mar 11, 2019
@analogrelay analogrelay deleted the anurse/skipathon-part-2 branch May 1, 2019 16:53
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranavkm pranavkm pranavkm left review comments

@Eilon Eilon Eilon approved these changes

@jkotalik jkotalik Awaiting requested review from jkotalik

@Tratcher Tratcher Awaiting requested review from Tratcher

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@analogrelay @pranavkm @Eilon @amcasey