-
Notifications
You must be signed in to change notification settings - Fork 10.4k
Skip flaky transport test #8295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The link to the failed build in the issue isn't working for me: https://dev.azure.com/dnceng/public/_build/results?buildId=116342&view=logs I see "The requested build 116342 could not be found." when I follow the link. |
That was a pr build. It was probably cleared out. Here are more recent issues https://github.com/aspnet/AspNetCore-Internal/issues/1886 https://github.com/aspnet/AspNetCore-Internal/issues/1910#event-2188177593 |
@@ -1494,7 +1494,7 @@ public void afterSuccessfulNegotiateConnectsWithLongPollingTransport() { | |||
assertEquals("{\"protocol\":\"json\",\"version\":1}" + RECORD_SEPARATOR, sentMessages[0]); | |||
} | |||
|
|||
@Test | |||
// Github issue:https://github.com/aspnet/AspNetCore/issues/8262 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use @Ignore
? http://junit.sourceforge.net/javadoc/org/junit/Ignore.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like we use Skip
in xUnit.net:
@Ignore("https://github.com/aspnet/AspNetCore/issues/8262")
@Test
...
cc @aspnet/brt A quick issue search with the test name didn't bring up any results. |
aspnet/AspNetCore-Internal#1913 |
Issue: #8262 and https://github.com/aspnet/AspNetCore-Internal/issues/1910#event-2188177593
Looking into fixing the test but it's causing failures so need to skip now
CC @aspnet/brt