Skip to content

Skip flaky transport test #8295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2019
Merged

Skip flaky transport test #8295

merged 2 commits into from
Mar 8, 2019

Conversation

mikaelm12
Copy link
Contributor

Issue: #8262 and https://github.com/aspnet/AspNetCore-Internal/issues/1910#event-2188177593

Looking into fixing the test but it's causing failures so need to skip now

CC @aspnet/brt

@halter73
Copy link
Member

halter73 commented Mar 7, 2019

The link to the failed build in the issue isn't working for me:

https://dev.azure.com/dnceng/public/_build/results?buildId=116342&view=logs

I see "The requested build 116342 could not be found." when I follow the link.

@mikaelm12
Copy link
Contributor Author

The link to the failed build in the issue isn't working for me:

That was a pr build. It was probably cleared out. Here are more recent issues https://github.com/aspnet/AspNetCore-Internal/issues/1886 https://github.com/aspnet/AspNetCore-Internal/issues/1910#event-2188177593

@@ -1494,7 +1494,7 @@ public void afterSuccessfulNegotiateConnectsWithLongPollingTransport() {
assertEquals("{\"protocol\":\"json\",\"version\":1}" + RECORD_SEPARATOR, sentMessages[0]);
}

@Test
// Github issue:https://github.com/aspnet/AspNetCore/issues/8262
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like we use Skip in xUnit.net:

@Ignore("https://github.com/aspnet/AspNetCore/issues/8262")
@Test
...

@Eilon Eilon added the area-signalr Includes: SignalR clients and servers label Mar 7, 2019
@mikaelm12
Copy link
Contributor Author

  Failed   E2ETests.PublishAndRunTests.PublishAndRun_Test(variant: Server: Kestrel, TFM: netcoreapp3.0, Type: Portable, Arch: x64)
  Error Message:
   System.Exception : dotnet publish exited with exit code : 1
  Stack Trace:
     at Microsoft.AspNetCore.Server.IntegrationTesting.ApplicationPublisher.Publish(DeploymentParameters deploymentParameters, ILogger logger) in /_/src/Hosting/Server.IntegrationTesting/src/ApplicationPublisher.cs:line 92
     at Microsoft.AspNetCore.Server.IntegrationTesting.ApplicationDeployer.DotnetPublish(String publishRoot) in /_/src/Hosting/Server.IntegrationTesting/src/Deployers/ApplicationDeployer.cs:line 87
     at Microsoft.AspNetCore.Server.IntegrationTesting.SelfHostDeployer.DeployAsync() in /_/src/Hosting/Server.IntegrationTesting/src/Deployers/SelfHostDeployer.cs:line 58
     at E2ETests.PublishAndRunTests.PublishAndRun_Test(TestVariant variant) in /home/vsts/work/1/s/src/MusicStore/test/MusicStore.E2ETests/PublishAndRunTests.cs:line 53
  --- End of stack trace from previous location where exception was thrown ---

cc @aspnet/brt A quick issue search with the test name didn't bring up any results.

@mikaelm12 mikaelm12 merged commit c0c2bb3 into master Mar 8, 2019
@BrennanConroy BrennanConroy deleted the mikaelm12/FlakyTransportTest branch March 8, 2019 02:34
@analogrelay
Copy link
Contributor

aspnet/AspNetCore-Internal#1913

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants