Returning rejected promises in HttpConnection #8315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikaelm12
requested review from
analogrelay,
BrennanConroy and
halter73
as code owners
BrennanConroy
approved these changes
Mar 8, 2019
| } | ||
|
|
||
| private constructTransport(transport: HttpTransportType) { | ||
| switch (transport) { | ||
| switch (transport) { | ||
| case HttpTransportType.WebSockets: | ||
| if (!this.options.WebSocket) { | ||
| throw new Error("'WebSocket' is not supported in your environment."); |
There was a problem hiding this comment.
And the ones in resolveTransport and resolveUrl?
There was a problem hiding this comment.
Errors in constructTransport and resolveTransport are caught and aggregated into a rejected Promise. resolveUrl is only used in the constructor so that should be fine just throwing an error
mikaelm12
added
area-signalr
halter73
reviewed
Mar 8, 2019
halter73
approved these changes
Mar 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7465
We were throwing in places we should have been returned rejected promises.