Skip to content

Fix SignalR transport test #8424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2019
Merged

Fix SignalR transport test #8424

merged 2 commits into from
Mar 12, 2019

Conversation

mikaelm12
Copy link
Contributor

Fixes: #8262

There was a race where the transport could stop before the HubConnection finished starting.

@mikaelm12 mikaelm12 changed the title Fix transport test Fix SignaR transport test Mar 12, 2019
@mikaelm12 mikaelm12 force-pushed the mikaelm12/FixTransportTest branch from df3ba8d to 94eac54 Compare March 12, 2019 00:35
@BrennanConroy
Copy link
Member

Shouldn't hubConnection.start().timeout(1, TimeUnit.SECONDS).blockingAwait(); be waiting for start to finish?

@mikaelm12
Copy link
Contributor Author

The issue was the hubConnection would continuously poll and before we could receive the 204 response between starting the transport and sending the handshake since we weren't blocking.

@BrennanConroy BrennanConroy added the area-signalr Includes: SignalR clients and servers label Mar 12, 2019
@BrennanConroy BrennanConroy changed the title Fix SignaR transport test Fix SignalR transport test Mar 12, 2019
BrennanConroy
BrennanConroy approved these changes Mar 12, 2019
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Handshake bug :(

@mikaelm12 mikaelm12 merged commit 5efa1ba into master Mar 12, 2019
@BrennanConroy BrennanConroy deleted the mikaelm12/FixTransportTest branch March 12, 2019 23:37
@dougbu dougbu mentioned this pull request Apr 6, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

Assignees
No one assigned
Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelm12 @BrennanConroy @halter73