Skip to content

Add tests for Worker template #8754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add tests for Worker template #8754

wants to merge 3 commits into from

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher added this to the 3.0.0-preview4 milestone Mar 22, 2019
@Tratcher Tratcher self-assigned this Mar 22, 2019
@Tratcher
Copy link
Member Author

Blocked on getting a new SDK. #8670

@Tratcher Tratcher added the blocked The work on this issue is blocked due to some dependency label Mar 25, 2019
@analogrelay
Copy link
Contributor

Is more work needed here beyond just getting the new SDK? I want to know if we should move this over to someone else or punt it in order to make space for Kerberos :)

@Tratcher
Copy link
Member Author

Tratcher commented Apr 1, 2019

Hard to tell until we get the SDK update. Need to rebase and see if the existing tests work.

@jkotalik
Copy link
Contributor

jkotalik commented Apr 2, 2019

This should now be unblocked.

@jkotalik jkotalik removed the blocked The work on this issue is blocked due to some dependency label Apr 2, 2019
@analogrelay
Copy link
Contributor

@Tratcher is the next step here as simple as rebasing/retriggering?

@Tratcher Tratcher force-pushed the tratcher/worktemptest branch from 8705bbf to 3d4dc5e Compare April 2, 2019 19:04
@Tratcher
Copy link
Member Author

Tratcher commented Apr 3, 2019

Rebased, but there's something wrong with my test that's causing a hang on all platforms.

@Tratcher Tratcher force-pushed the tratcher/worktemptest branch from 3d4dc5e to 9c35b86 Compare April 11, 2019 21:52
@Tratcher
Copy link
Member Author

@ryanbrandenburg already did most of this in #8628. I just need to re-enable the test. Closing this PR.

@Tratcher Tratcher closed this Apr 19, 2019
@Tratcher Tratcher deleted the tratcher/worktemptest branch April 19, 2019 17:24
@ryanbrandenburg ryanbrandenburg added Done This issue has been fixed cost: XS labels Apr 19, 2019
@amcasey amcasey added the area-hosting Includes Hosting label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanbrandenburg ryanbrandenburg

Labels
area-hosting Includes Hosting Done This issue has been fixed
Projects
None yet
Milestone
3.0.0-preview6
Development

Successfully merging this pull request may close these issues.
6 participants
@Tratcher @analogrelay @jkotalik @Eilon @amcasey @ryanbrandenburg