Skip to content

Add more eslint rules and apply auto fixes #9004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 4, 2019
Merged

Add more eslint rules and apply auto fixes #9004

merged 3 commits into from
Apr 4, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Apr 2, 2019 •
edited
Loading

Added more config rules for eslint and ran eslint --config .\src\.eslintrc.js .\src\**\*.ts --fix to standarize the codebase style as much as possible.

@mkArtakMSFT mkArtakMSFT added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Apr 2, 2019
SteveSandersonMS
SteveSandersonMS approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@javiercn javiercn merged commit 237b19b into master Apr 4, 2019
@javiercn javiercn deleted the javiercn/components-eslint branch April 4, 2019 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@javiercn @SteveSandersonMS @mkArtakMSFT