Client to Server Streaming with IAsyncEnumerable #9310
Conversation
mikaelm12
requested review from
analogrelay,
BrennanConroy and
halter73
as code owners
| #if NETCOREAPP3_0 | ||
| if (ReflectionHelper.IsIAsyncEnumerable(reader.GetType())) | ||
| { | ||
| _ = _sendIAsyncStreamItemsMethod |
There was a problem hiding this comment.
Long term, we should store the Takss returned by _sendIAsyncStreamItemsMethod and _sendStreamItemsMethod and track them during connection teardown and log warnings if they don't complete within a timeout.
mikaelm12
changed the title
src/SignalR/clients/csharp/Client/test/FunctionalTests/HubConnectionTests.cs
Outdated
Show resolved
Hide resolved
|
⬆️ 📅 |
|
Hm there was a failure in one of the tests on the Mac Agent This means that the stream type wasn't detected on the client side and there the invocation didn't register the streaming id with the server. |
|
The error seemed to be an issue with how the MessagePackHubProtocol was (or was not actually) handling StreamBindingFailureMessages. It was just throwing instead of sending the binding failure messages |
|
This comment was made automatically. If there is a problem contact ryanbrandenburg. I've triaged the above build. I've created/commented on the following issue(s) |
| if (ReflectionHelper.IsIAsyncEnumerable(reader.GetType())) | ||
| { | ||
| _ = _sendIAsyncStreamItemsMethod | ||
| .MakeGenericMethod(reader.GetType().GetInterface("IAsyncEnumerable`1").GetGenericArguments()) |
| var connection = CreateHubConnection(server.Url, path, transportType, protocol, LoggerFactory); | ||
| try | ||
| { | ||
| async IAsyncEnumerable<string> clientStreamData() |
There was a problem hiding this comment.
Is the case settled on local functions? I could see the argument for using camelCase like you would for anything else with a local scope.
There was a problem hiding this comment.
Yes it settled it’s always pascal case because this is c# not java or JavaScript
Not ready for review. Just hacking something that works together.Time for some eyes on this. Got rid of a lot of similar code.We're essentially adding checks for an
IAsyncEnumerabletype in the invocation params, associated themwith a stream id similarly to how we do with channels, then consume items from the stream and send them asStreamItemmessages.